Feat: Configurable RPC Apis #349

crypto-facs · 2021-07-25T17:44:29Z

Closes: #174

Description

Given that we now support some debug endpoints. It is necessary to allow nodes to enable the desired api namespaces to avoid undesired stress on the nodes from expensive requests.

This PR just enables to specify which namespaces to have open from the namespaces that we support. Left eth namespace open by default.

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

docs/basics/json_rpc.md

ethereum/rpc/apis.go

leejw51crypto

lgtm

fedekunze

Looks good! minor comments

CHANGELOG.md

cmd/ethermintd/config/config.go

ethereum/rpc/apis.go

init.sh

server/start.go

tests/solidity/init-test-node.sh

Co-authored-by: Federico Kunze Küllmer <[email protected]>

…into configurable-rpcs

fedekunze

LGTM. The only thing left is preventing adding the APIs namespaces more than once (convert slice to set)

ethereum/rpc/apis.go

testutil/network/util.go

server/evmrpc.go

CHANGELOG.md

docs/basics/json_rpc.md

* Problem: native action could results inconsistent balance Solution: - change statedb's balance operation to native fix unit tests * fix unit test * Update x/evm/keeper/keeper.go Signed-off-by: yihuang <[email protected]> * fix lint * Update x/evm/keeper/keeper.go Co-authored-by: mmsqe <[email protected]> Signed-off-by: yihuang <[email protected]> --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: mmsqe <[email protected]>

crypto-facs added 5 commits July 22, 2021 16:52

fix confusing name

f65707c

feat: Enable configurable grpc apis

84d475d

docs: Update docs and changelog

6fb66fe

Organized flags order

89416b5

merge conflicts

e097d36

crypto-facs requested a review from fedekunze July 25, 2021 17:44

crypto-facs requested a review from khoslaventures as a code owner July 25, 2021 17:44

crypto-facs added 4 commits July 25, 2021 19:50

fix linter

b65d49a

fix linter

ce5087d

fix maligned struct

144b388

Merge branch 'main' into configurable-rpcs

c131a06

yihuang reviewed Jul 26, 2021

View reviewed changes

docs/basics/json_rpc.md Outdated Show resolved Hide resolved

ethereum/rpc/apis.go Outdated Show resolved Hide resolved

thomas-nguy reviewed Jul 26, 2021

View reviewed changes

ethereum/rpc/apis.go Outdated Show resolved Hide resolved

leejw51crypto approved these changes Jul 26, 2021

View reviewed changes

crypto-facs added 2 commits July 26, 2021 09:20

fix typo in docs

073aa9d

fix unnecesary duplicate

2929380

fedekunze suggested changes Jul 26, 2021

View reviewed changes

crypto-facs and others added 12 commits July 26, 2021 09:40

Update cmd/ethermintd/config/config.go

1c50243

Co-authored-by: Federico Kunze Küllmer <[email protected]>

Update cmd/ethermintd/config/config.go

dcebdc0

Co-authored-by: Federico Kunze Küllmer <[email protected]>

Update cmd/ethermintd/config/config.go

ebfb6de

Co-authored-by: Federico Kunze Küllmer <[email protected]>

Update docs/basics/json_rpc.md

2d93d8e

Co-authored-by: Federico Kunze Küllmer <[email protected]>

fix eth to be manage as default

960cb40

Update init.sh

3010993

Co-authored-by: Federico Kunze Küllmer <[email protected]>

Update tests/solidity/init-test-node.sh

ac03109

Co-authored-by: Federico Kunze Küllmer <[email protected]>

add default case

bb6bfa4

Merge branch 'configurable-rpcs' of github.com:crypto-facs/ethermint …

6ce870b

…into configurable-rpcs

add default enable api namespaces

277bce6

update changelog

5048f20

fix namespaces array handler

d9a0ace

fedekunze approved these changes Jul 26, 2021

View reviewed changes

crypto-facs added 4 commits July 26, 2021 10:41

remove duplicated changelog

3c4032a

fix typo

43b0f7b

remove duplicates namespaces and fix eth namespace issue

bb9aa27

fix variable name

129f154

fedekunze reviewed Jul 26, 2021

View reviewed changes

docs/basics/json_rpc.md Outdated Show resolved Hide resolved

docs/basics/json_rpc.md Outdated Show resolved Hide resolved

crypto-facs and others added 2 commits July 26, 2021 12:50

break line in docs

4e554bf

Merge branch 'main' into configurable-rpcs

994b817

fedekunze enabled auto-merge (squash) July 26, 2021 11:08

fedekunze merged commit d121272 into evmos:main Jul 26, 2021

crypto-facs deleted the configurable-rpcs branch July 26, 2021 11:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Configurable RPC Apis #349

Feat: Configurable RPC Apis #349

crypto-facs commented Jul 25, 2021

leejw51crypto left a comment

fedekunze left a comment

fedekunze left a comment

Feat: Configurable RPC Apis #349

Feat: Configurable RPC Apis #349

Conversation

crypto-facs commented Jul 25, 2021

Description

leejw51crypto left a comment

Choose a reason for hiding this comment

fedekunze left a comment

Choose a reason for hiding this comment

fedekunze left a comment

Choose a reason for hiding this comment