This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
fix evm parameters and block gas limit in getBlockByHeight and getBlockByHash #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-nguy
force-pushed
the
thomas/302-FixMultiCall
branch
from
f801170 to
cdd1322
Compare
Codecov Report
@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 47.60% 47.46% -0.14%
==========================================
Files 46 46
Lines 3151 3160 +9
==========================================
Hits 1500 1500
- Misses 1576 1585 +9
Partials 75 75
|
thomas-nguy
force-pushed
the
thomas/302-FixMultiCall
branch
from
cdd1322 to
73c0f3a
Compare
thomas-nguy
changed the title
thomas-nguy
changed the title
fedekunze
approved these changes
Jul 16, 2021
x/evm/keeper/state_transition.go
Outdated
Comment on lines
70
to
71
| // Note: we cannot use k.ctx.HeaderHash() because the headerHash it set only at begin block | ||
| // so it won't be set in case of simulated context |
There was a problem hiding this comment.
isn't it set for checkTxState too? can you open an issue on the SDK to fix this and include it on v0.43?
There was a problem hiding this comment.
It is also set for checkContext.
I realised my comment might be confusing. What I want to mean is that in case of a "query" context, such as simulating a transaction through "EthCall", then the header hash won't be set.
I have rewrote the comment, let me know if its clear now
thomas-nguy
force-pushed
the
thomas/302-FixMultiCall
branch
from
fcb671c to
9dea9e2
Compare
thomas-nguy
force-pushed
the
thomas/302-FixMultiCall
branch
from
9dea9e2 to
f2b707e
Compare
fedekunze
approved these changes
Jul 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #302
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)