Problem: etherjs smartcontract cannot change state (fix #257)

[leejw51crypto]

Solution: increase base gas to make similar with ethereum

[thomas-nguy]

I have tried current main and its consistent with infura (no contract call)

I think its better to fix the calculation rather than add a fixed value.

➜  ethermint git:(thomas/gas_estimate) ✗ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_estimateGas","params":[{"from":"0x7cB61D4117AE31a12E393a1Cfa3BaC666481D02E", "to":"0x11f4d0A3c12e86B4b5F39B213F7E19D048276DAe", "data":"0xc6888fa10000000000000000000000000000000000000000000000000000000000000003"}],"id":1}'  -H "Content-Type: application/json" http://localhost:8545
{"jsonrpc":"2.0","id":1,"result":"0x52d4"}
➜  ethermint git:(thomas/gas_estimate) ✗ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_estimateGas","params":[{"from":"0x7cB61D4117AE31a12E393a1Cfa3BaC666481D02E", "to":"0x11f4d0A3c12e86B4b5F39B213F7E19D048276DAe", "data":"0xc6888fa10000000000000000000000000000000000000000000000000000000000000003"}],"id":1}'  -H "Content-Type: application/json" https://ropsten.infura.io/v3/<project_id>
{"jsonrpc":"2.0","id":1,"result":"0x52d4"}%

➜  ethermint git:(thomas/gas_estimate) ✗ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_estimateGas","params":[{"from":"0x7cB61D4117AE31a12E393a1Cfa3BaC666481D02E", "to":"0x7cB61D4117AE31a12E393a1Cfa3BaC666481D02E", "value":"0x16345785d8a00000"}],"id":1}'  -H "Content-Type: application/json" https://ropsten.infura.io/v3/<projectId>
{"jsonrpc":"2.0","id":1,"result":"0x5208"}%
➜  ethermint git:(thomas/gas_estimate) ✗ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_estimateGas","params":[{"from":"0x7cB61D4117AE31a12E393a1Cfa3BaC666481D02E", "to":"0x7cB61D4117AE31a12E393a1Cfa3BaC666481D02E", "value":"0x16345785d8a00000"}],"id":1}'  -H "Content-Type: application/json" http://localhost:8545
{"jsonrpc":"2.0","id":1,"result":"0x5208"}

[leejw51crypto]

ok , i'll find a way to compute

[thomas-nguy]

check this method
https://github.com/tharsis/ethermint/blob/main/x/evm/keeper/state_transition.go#L262

(it refund max half consumed, maybe the logic is different with geth)

[yijiasu]

I have tried current main and its consistent with infura (no contract call)

I think its better to fix the calculation rather than add a fixed value.

➜  ethermint git:(thomas/gas_estimate) ✗ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_estimateGas","params":[{"from":"0x7cB61D4117AE31a12E393a1Cfa3BaC666481D02E", "to":"0x11f4d0A3c12e86B4b5F39B213F7E19D048276DAe", "data":"0xc6888fa10000000000000000000000000000000000000000000000000000000000000003"}],"id":1}'  -H "Content-Type: application/json" http://localhost:8545
{"jsonrpc":"2.0","id":1,"result":"0x52d4"}
➜  ethermint git:(thomas/gas_estimate) ✗ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_estimateGas","params":[{"from":"0x7cB61D4117AE31a12E393a1Cfa3BaC666481D02E", "to":"0x11f4d0A3c12e86B4b5F39B213F7E19D048276DAe", "data":"0xc6888fa10000000000000000000000000000000000000000000000000000000000000003"}],"id":1}'  -H "Content-Type: application/json" https://ropsten.infura.io/v3/<project_id>
{"jsonrpc":"2.0","id":1,"result":"0x52d4"}%

➜  ethermint git:(thomas/gas_estimate) ✗ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_estimateGas","params":[{"from":"0x7cB61D4117AE31a12E393a1Cfa3BaC666481D02E", "to":"0x7cB61D4117AE31a12E393a1Cfa3BaC666481D02E", "value":"0x16345785d8a00000"}],"id":1}'  -H "Content-Type: application/json" https://ropsten.infura.io/v3/<projectId>
{"jsonrpc":"2.0","id":1,"result":"0x5208"}%
➜  ethermint git:(thomas/gas_estimate) ✗ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_estimateGas","params":[{"from":"0x7cB61D4117AE31a12E393a1Cfa3BaC666481D02E", "to":"0x7cB61D4117AE31a12E393a1Cfa3BaC666481D02E", "value":"0x16345785d8a00000"}],"id":1}'  -H "Content-Type: application/json" http://localhost:8545
{"jsonrpc":"2.0","id":1,"result":"0x5208"}

If the calculation is equal to the value from infura, then there's no issue at all. It's expected to have the same gas value from any existing Etherum network

what's going wrong here?

Is 0x52d4 (dec. 21204) enough for executing the call? What's the value in its compiled ABI?

[leejw51crypto]

21204 is not enough, it should be equal or above than 41646,
i tried 41645, not working

Ganache: 0xa2ae = 41646
Tharsis: 0x52d4 = 21204

[yihuang]

21204 is not enough, it should be equal or above than 41646,
i tried 41645, not working

Ganache: 0xa2ae = 41646
Tharsis: 0x52d4 = 21204

Probably this issue: #268

[thomas-nguy]

Is 0x52d4 (dec. 21204) enough for executing the call? What's the value in its compiled ABI?

I used the example from the rpc doc. I think its just a memo.

@leejw51crypto what is your code to return 0xa2ae = 41646 ?

BTW the gas is a dynamic value, it depends on what you are calling, so you cannot assume we can use the same value for all

[leejw51crypto]

return hexutil.Uint64(data.GasUsed + 40000), nil

i added 40000

[leejw51crypto]

i'll rebase after
#268 is resolved

if EstimateGas returns correct estimation,
then this pr can be closed

[leejw51crypto]

closed by
#272