Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

feat: Cosmos SDK v47 integration #1782

Closed
wants to merge 58 commits into from
Closed

feat: Cosmos SDK v47 integration #1782

wants to merge 58 commits into from

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jun 5, 2023

Reopen #1687

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@@ -196,7 +196,7 @@
args.chainID, _ = cmd.Flags().GetString(flags.FlagChainID)
args.minGasPrices, _ = cmd.Flags().GetString(sdkserver.FlagMinGasPrices)
args.numValidators, _ = cmd.Flags().GetInt(flagNumValidators)
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyAlgorithm)
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyType)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack.

Returned error is not propagated up the stack.
@@ -161,7 +161,7 @@
args.nodeDaemonHome, _ = cmd.Flags().GetString(flagNodeDaemonHome)
args.startingIPAddress, _ = cmd.Flags().GetString(flagStartingIPAddress)
args.numValidators, _ = cmd.Flags().GetInt(flagNumValidators)
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyAlgorithm)
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyType)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack.

Returned error is not propagated up the stack.
@@ -75,7 +76,7 @@
interactive, _ := cmd.Flags().GetBool(flagInteractive)
noBackup, _ := cmd.Flags().GetBool(flagNoBackup)
useLedger, _ := cmd.Flags().GetBool(flags.FlagUseLedger)
algoStr, _ := cmd.Flags().GetString(flags.FlagKeyAlgorithm)
algoStr, _ := cmd.Flags().GetString(flags.FlagKeyType)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack.

Returned error is not propagated up the stack.
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #1782 (331a437) into main (10d9579) will decrease coverage by 0.02%.
The diff coverage is 72.24%.

❗ Current head 331a437 differs from pull request most recent head 373b493. Consider uploading reports for the commit 373b493 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1782      +/-   ##
==========================================
- Coverage   68.89%   68.88%   -0.02%     
==========================================
  Files         117      117              
  Lines       10681    10824     +143     
==========================================
+ Hits         7359     7456      +97     
- Misses       2900     2936      +36     
- Partials      422      432      +10     
Impacted Files Coverage Δ
app/ante/ante.go 58.13% <ø> (ø)
app/ante/eip712.go 58.46% <ø> (ø)
app/ante/handler_options.go 71.69% <ø> (ø)
client/config.go 23.07% <ø> (ø)
client/keys.go 0.00% <0.00%> (ø)
client/testnet.go 0.00% <0.00%> (ø)
crypto/ethsecp256k1/ethsecp256k1.go 65.71% <ø> (ø)
encoding/config.go 100.00% <ø> (ø)
ethereum/eip712/encoding.go 78.00% <ø> (ø)
indexer/kv_indexer.go 64.96% <ø> (ø)
... and 28 more

@mmsqe mmsqe marked this pull request as ready for review June 7, 2023 12:21
@mmsqe mmsqe requested a review from a team as a code owner June 7, 2023 12:21
@mmsqe mmsqe requested review from facs95 and MalteHerrmann and removed request for a team June 7, 2023 12:21
@@ -274,7 +274,7 @@ func (suite *AnteTestSuite) TestRejectDeliverMsgsInAuthz() {
},
),
},
expectedCode: sdkerrors.ErrUnauthorized.ABCICode(),
expectedCode: sdkerrors.ErrUnpackAny.ABCICode(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err code change, for more info

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants