-
Notifications
You must be signed in to change notification settings - Fork 566
Conversation
update to sdk v0.47.2 newer btcutil
@@ -196,7 +196,7 @@ | |||
args.chainID, _ = cmd.Flags().GetString(flags.FlagChainID) | |||
args.minGasPrices, _ = cmd.Flags().GetString(sdkserver.FlagMinGasPrices) | |||
args.numValidators, _ = cmd.Flags().GetInt(flagNumValidators) | |||
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyAlgorithm) | |||
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyType) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
@@ -161,7 +161,7 @@ | |||
args.nodeDaemonHome, _ = cmd.Flags().GetString(flagNodeDaemonHome) | |||
args.startingIPAddress, _ = cmd.Flags().GetString(flagStartingIPAddress) | |||
args.numValidators, _ = cmd.Flags().GetInt(flagNumValidators) | |||
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyAlgorithm) | |||
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyType) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
@@ -75,7 +76,7 @@ | |||
interactive, _ := cmd.Flags().GetBool(flagInteractive) | |||
noBackup, _ := cmd.Flags().GetBool(flagNoBackup) | |||
useLedger, _ := cmd.Flags().GetBool(flags.FlagUseLedger) | |||
algoStr, _ := cmd.Flags().GetString(flags.FlagKeyAlgorithm) | |||
algoStr, _ := cmd.Flags().GetString(flags.FlagKeyType) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1782 +/- ##
==========================================
- Coverage 68.89% 68.88% -0.02%
==========================================
Files 117 117
Lines 10681 10824 +143
==========================================
+ Hits 7359 7456 +97
- Misses 2900 2936 +36
- Partials 422 432 +10
|
fix evm
@@ -274,7 +274,7 @@ func (suite *AnteTestSuite) TestRejectDeliverMsgsInAuthz() { | |||
}, | |||
), | |||
}, | |||
expectedCode: sdkerrors.ErrUnauthorized.ABCICode(), | |||
expectedCode: sdkerrors.ErrUnpackAny.ABCICode(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
err code change, for more info
This reverts commit 2c58a53.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
Reopen #1687
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)