This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
fix(evm): revert v4 migration changes #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
Vvaradinov and
GAtom22
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1625 +/- ##
==========================================
+ Coverage 68.15% 68.17% +0.02%
==========================================
Files 112 112
Lines 10141 10157 +16
==========================================
+ Hits 6912 6925 +13
- Misses 2825 2827 +2
- Partials 404 405 +1
|
…nt into fedekunze/params-migration
…/ethermint into fedekunze/params-migration
Vvaradinov
approved these changes
Jan 23, 2023
|
https://github.com/Mergifyio backport release/v0.21.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
* fix(evm): revert v4 migration changes * add check for chainID * fix: renamed vars to avoid duplicate proto * test * fix: set default extraEIPs to nil * fix: updated tests Co-authored-by: Vladislav Varadinov <[email protected]> (cherry picked from commit 9bfa1ff)
MalteHerrmann
pushed a commit
that referenced
this pull request
Jan 23, 2023
* fix(evm): revert v4 migration changes * add check for chainID * fix: renamed vars to avoid duplicate proto * test * fix: set default extraEIPs to nil * fix: updated tests Co-authored-by: Vladislav Varadinov <[email protected]> (cherry picked from commit 9bfa1ff) Co-authored-by: Federico Kunze Küllmer <[email protected]>
This was referenced Jan 24, 2023
fedekunze
added a commit
that referenced
this pull request
Jan 25, 2023
* release: v0.21.0-rc1 changelog (#1606) * changelog: added rc-1 changelog entry * fix: typo fix rc1 * fix(rpc): bind default json-rpc listen address to localhost (backport #1613) (#1621) * fix(rpc): bind default json-rpc listen address to localhost (#1613) * update nix * bind default json-rpc to 127.0.0.1 * add change doc * Update CHANGELOG.md Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> (cherry picked from commit 3587015) # Conflicts: # CHANGELOG.md * address merge conflicts Co-authored-by: mmsqe <[email protected]> Co-authored-by: MalteHerrmann <[email protected]> * fix(rpc): align fee history (backport #1611) (#1620) * fix(rpc): align fee history (#1611) * update nix * add next fee in fee history * fix test * add change doc * height + 1 for next fee * cross check baseFeePerGas len * Update tests/integration_tests/test_fee_history.py Co-authored-by: MalteHerrmann <[email protected]> * fix oldestBlock & align earliest input as eth * update doc * update nix * isort test_fee_history.py * fix test * align rpc res as eth * add cross check * add baseFeePerGas len check * add oldestBlock check Co-authored-by: MalteHerrmann <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> (cherry picked from commit 47fdfd3) # Conflicts: # CHANGELOG.md * address merge conflicts Co-authored-by: mmsqe <[email protected]> Co-authored-by: MalteHerrmann <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> * support customize db opener in `StartCmd` (backport #1615) (#1622) * support customize db opener in `StartCmd` (#1615) * support customize db opener in `StartCmd` * Update CHANGELOG.md * pass to dbOpener, so we can control different options through cli flags * add comments (cherry picked from commit f1337aa) # Conflicts: # CHANGELOG.md * conflicts Co-authored-by: yihuang <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> * tests(evm): add benchmark tests setup for params (#1623) (#1627) * tests: add benchmark tests setup * fix: localized benchmark tests to keeper * update benchmark Co-authored-by: Federico Kunze Küllmer <[email protected]> (cherry picked from commit 9305788) Co-authored-by: Vladislav Varadinov <[email protected]> * refactor(params): store all params under one key in evm module (backport #1617) (#1626) * refactor(params): store all params under one key in evm module (#1617) * refactor(params): store all params under one key in evm module * refactor(params): add changelog entry * refactor(params): update based on review comments. Remove params getter functions * refactor(params): refactor params store key * refactor(params): remove unnecessary store keys * refactor(params): add paramSetPairs for backwards compatibility * Update CHANGELOG.md * refactor(params): add license to params_legacy file * Apply suggestions from code review * fix(evm): handle RC1 params during migration (#1624) * fix(evm): handle RC1 params during migration * migration * fix: test case updated for RC1 * v5 migration * tests * tests pt2 * comment * execute make proto-all Co-authored-by: Vladislav Varadinov <[email protected]> Co-authored-by: MalteHerrmann <[email protected]> * Apply suggestions from code review * rm dup vars Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Vladislav Varadinov <[email protected]> Co-authored-by: MalteHerrmann <[email protected]> (cherry picked from commit f07b14f) # Conflicts: # CHANGELOG.md * update changelog Co-authored-by: Tomas Guerra <[email protected]> Co-authored-by: MalteHerrmann <[email protected]> Co-authored-by: MalteHerrmann <[email protected]> * fix(evm): revert v4 migration changes (#1625) (#1628) * fix(evm): revert v4 migration changes * add check for chainID * fix: renamed vars to avoid duplicate proto * test * fix: set default extraEIPs to nil * fix: updated tests Co-authored-by: Vladislav Varadinov <[email protected]> (cherry picked from commit 9bfa1ff) Co-authored-by: Federico Kunze Küllmer <[email protected]> * minor improvement to changelog (#1629) * adjust year to 2023 for v0.21.0-rc2 release (#1630) * Update CHANGELOG.md Co-authored-by: Vladislav Varadinov <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: mmsqe <[email protected]> Co-authored-by: mmsqe <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: Tomas Guerra <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)