-
Notifications
You must be signed in to change notification settings - Fork 562
refactor: optimize AnteHandler gas consumption #1388
Conversation
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1388 +/- ##
==========================================
+ Coverage 55.88% 56.00% +0.12%
==========================================
Files 108 108
Lines 10021 10049 +28
==========================================
+ Hits 5600 5628 +28
Misses 4140 4140
Partials 281 281
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Federico Kunze Küllmer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice @Vvaradinov, I reviewed the changes and left a nit comment. Feel free to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why we were calling the params as a set in the places I pointed out was not to make the query several time per property and per message. I liked the idea of making the code cleaner but maybe we can find a way in which is clear but keeps same - or better performance
This reverts commit 83e509b.
Description
This PR aims to optimize gas consumption by reordering AnteHandlers by executing stateless ones first followed by stateful ones. Additionally it provides specific getters for each individual parameter in the keeper and only calls ones needed by the particular AnteHandler.
Closes: ENG-905 ENG-444
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)