Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Prune Node Integration Tests #1212

Merged
merged 22 commits into from
Aug 8, 2022
Merged

Prune Node Integration Tests #1212

merged 22 commits into from
Aug 8, 2022

Conversation

facs95
Copy link
Contributor

@facs95 facs95 commented Jul 28, 2022 •
edited
Loading

Closes: #XXX

Description

Integration tests for pruned nodes based on @yihuang tests on cronos."

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@facs95 facs95 marked this pull request as draft July 28, 2022 14:48
@facs95 facs95 changed the title Pruned tests Prune Node Integration Tests Jul 28, 2022
facs95
facs95 commented Aug 1, 2022
View reviewed changes
Copy link
Contributor Author

@facs95 facs95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ramacarlucho for helping with the PR 🙏 ! Left a couple of comments for things that I believe should be changed before we merge this

rpc/backend/evm_backend.go Outdated Show resolved Hide resolved
tests/integration_tests/configs/pruned_node.jsonnet Outdated Show resolved Hide resolved
@yihuang
Copy link
Contributor

yihuang commented Aug 1, 2022

https://github.com/evmos/ethermint/runs/7587033616?check_suite_focus=true

The integration test is not running, I had a fix in another PR: #1214

@yihuang yihuang mentioned this pull request Aug 3, 2022
Merged
11 tasks
@codecov
Copy link

codecov bot commented Aug 3, 2022 •
edited
Loading

Codecov Report

Merging #1212 (f2233d3) into main (7331cd2) will decrease coverage by 0.01%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1212      +/-   ##
==========================================
- Coverage   57.21%   57.20%   -0.02%     
==========================================
  Files          94       94              
  Lines        8419     8424       +5     
==========================================
+ Hits         4817     4819       +2     
- Misses       3356     3358       +2     
- Partials      246      247       +1
Impacted Files Coverage Δ
app/export.go 12.92% <ø> (ø)
rpc/backend/backend.go 86.66% <ø> (ø)
rpc/types/query_client.go 0.00% <ø> (ø)
x/evm/keeper/state_transition.go 76.90% <ø> (ø)
x/evm/statedb/statedb.go 99.20% <ø> (ø)
x/evm/types/logs.go 30.58% <0.00%> (ø)
x/evm/types/tx_data.go 97.91% <ø> (ø)
x/evm/keeper/keeper.go 80.00% <57.14%> (-1.25%) ⬇️

@facs95 facs95 marked this pull request as ready for review August 3, 2022 15:52
@facs95 facs95 requested a review from danburck as a code owner August 3, 2022 15:52
yihuang
yihuang reviewed Aug 4, 2022
View reviewed changes
rpc/backend/evm_backend.go Outdated Show resolved Hide resolved
yihuang
yihuang approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facs95 facs95 enabled auto-merge (squash) August 4, 2022 13:52
fedekunze
fedekunze reviewed Aug 4, 2022
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment. We should only get the EVM denom from the params

x/evm/keeper/keeper.go Outdated Show resolved Hide resolved
@facs95 facs95 disabled auto-merge August 4, 2022 14:34
fedekunze
fedekunze approved these changes Aug 5, 2022
View reviewed changes
rpc/namespaces/ethereum/eth/api.go Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) August 5, 2022 06:18
@fedekunze
Copy link
Contributor

Gosec is prob failing because you're using a fork (?). I'll merge the PR

@fedekunze fedekunze disabled auto-merge August 8, 2022 08:16
@fedekunze fedekunze merged commit ccbaf1f into evmos:main Aug 8, 2022
@facs95 facs95 deleted the pruned-tests branch August 8, 2022 09:52
facs95 added a commit that referenced this pull request Aug 12, 2022
@facs95 @ramacarlucho @fedekunze
imp(tests): prune node integration tests (#1212)
5e16116 
* first pass

* extra comment

* fixed pruned node tests. Fix getBalance on pruned. Fix BaseFee on pruned.

* fix tests execution

* check logs on tests

* address pr comments

* address comments

* Update rpc/namespaces/ethereum/eth/api.go

* update error msg check

* fix lint

* fix linter

* fix linter

* fix py lint

* test lint

* fix lint

* pin golangcli version

* pin golanci version

* pin lint to version 0.48

* fix linter

* fix last linter last file

Co-authored-by: ramacarlucho <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Aug 17, 2022
@facs95 @ramacarlucho @fedekunze
imp(tests): prune node integration tests (evmos#1212)
e6e4f03 
* first pass

* extra comment

* fixed pruned node tests. Fix getBalance on pruned. Fix BaseFee on pruned.

* fix tests execution

* check logs on tests

* address pr comments

* address comments

* Update rpc/namespaces/ethereum/eth/api.go

* update error msg check

* fix lint

* fix linter

* fix linter

* fix py lint

* test lint

* fix lint

* pin golangcli version

* pin golanci version

* pin lint to version 0.48

* fix linter

* fix last linter last file

Co-authored-by: ramacarlucho <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Nov 17, 2022
@facs95 @devon-chain
imp(tests): prune node integration tests (evmos#1212)
30c9604 
* first pass

* extra comment

* fixed pruned node tests. Fix getBalance on pruned. Fix BaseFee on pruned.

* fix tests execution

* check logs on tests

* address pr comments

* address comments

* Update rpc/namespaces/ethereum/eth/api.go

* update error msg check

* fix lint

* fix linter

* fix linter

* fix py lint

* test lint

* fix lint

* pin golangcli version

* pin golanci version

* pin lint to version 0.48

* fix linter

* fix last linter last file

Co-authored-by: ramacarlucho <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
(cherry picked from commit 5e16116)
@danburck danburck mentioned this pull request Nov 30, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@yihuang yihuang yihuang approved these changes

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

@jolube jolube Awaiting requested review from jolube

@danburck danburck Awaiting requested review from danburck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@facs95 @yihuang @fedekunze @ramacarlucho