Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix(evm): clear logs if tx failed in post processing hooks #1128

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Jun 15, 2022

Description

When tx fail in post processing hooks, the whole tx is reverted, so we should clear the logs too.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #1128 (6899a7b) into main (8f932dd) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
- Coverage   61.74%   61.69%   -0.05%     
==========================================
  Files          89       89              
  Lines        7303     7308       +5     
==========================================
  Hits         4509     4509              
- Misses       2570     2575       +5     
  Partials      224      224              
Impacted Files Coverage Δ
x/evm/keeper/state_transition.go 74.32% <0.00%> (-1.13%) ⬇️

@fedekunze fedekunze changed the title Problem: clear logs if tx failed in post processing hooks fix(evm): clear logs if tx failed in post processing hooks Jun 21, 2022
@fedekunze fedekunze merged commit 6cf2b9f into evmos:main Jun 21, 2022
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Jun 22, 2022
* Problem: clear logs if tx failed in post processing hooks

* Update x/evm/keeper/state_transition.go

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants