feat!: Reject not replay-protected tx to prevent replay attack

[yihuang]

Description

Closes: #1122

• reject such txs in ante handler

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #1124 (40888a0) into main (8283530) will decrease coverage by 0.12%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##             main    #1124      +/-   ##
==========================================
- Coverage   61.86%   61.74%   -0.13%     
==========================================
  Files          88       89       +1     
  Lines        7285     7303      +18     
==========================================
+ Hits         4507     4509       +2     
- Misses       2557     2570      +13     
- Partials      221      224       +3     

Impacted Files	Coverage Δ
x/evm/keeper/migrations.go	66.66% <0.00%> (-33.34%)	⬇️
x/evm/types/tx_data.go	97.91% <ø> (ø)
x/evm/migrations/v2/migrate.go	42.85% <42.85%> (ø)
x/evm/module.go	52.85% <60.00%> (-0.88%)	⬇️
app/ante/eth.go	80.61% <100.00%> (-2.06%)	⬇️
x/evm/types/params.go	100.00% <100.00%> (ø)

[crypto-facs]

LGMT! 🙏

[fedekunze]

Looks good, see comments. Can we rename RejectUnprotected to RejectUnprotectedTx

We should also add a comment on NewTxDataFromTx and the proto type saying that the LegacyTx type only works in unprotected mode if the module parameter is disabled.

and on the proto file too

// on proto/ethermint/evm/tx.proto 

// LegacyTx is the transaction data of regular Ethereum transactions.
// NOTE: All non-protected transactions (i.e non EIP155 signed) will fail if the RejectUnprotectedTx parameter is enabled. 
message LegacyTx { 

[fedekunze]

@yihuang we should also add a non-breaking change to the JSON-RPC config to disable this (see geth flag below). I guess that some node providers will want this functionality even when the chain supports non-protected txs:

--rpc.allow-unprotected-txs         Allow for unprotected (non EIP155 signed) transactions to be submitted via RPC

We can add this in a follow-up PR

[yihuang]

@yihuang we should also add a non-breaking change to the JSON-RPC config to disable this (see geth flag below). I guess that some node providers will want this functionality even when the chain supports non-protected txs:

--rpc.allow-unprotected-txs         Allow for unprotected (non EIP155 signed) transactions to be submitted via RPC

We can add this in a follow-up PR

But we have implemented in consensus parameters, do you mean if it's not rejected in consensus level, add a flag to reject in mempool or rpc level only?

[yihuang]

Looks good, see comments. Can we rename RejectUnprotected to RejectUnprotectedTx

We should also add a comment on NewTxDataFromTx and the proto type saying that the LegacyTx type only works in unprotected mode if the module parameter is disabled.

and on the proto file too

// on proto/ethermint/evm/tx.proto 

// LegacyTx is the transaction data of regular Ethereum transactions.
// NOTE: All non-protected transactions (i.e non EIP155 signed) will fail if the RejectUnprotectedTx parameter is enabled. 
message LegacyTx { 

done