Emit eth tx hash in ante handler to support query failed transactions #1062

yihuang · 2022-04-21T13:54:50Z

Description

WIP: #1045
Solution:

emit eth tx hash in ante handler
modify rpc apis to use it

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

CHANGELOG.md

codecov · 2022-04-22T03:44:39Z

Codecov Report

Merging #1062 (c99ba46) into main (afc09f9) will increase coverage by 1.11%.
The diff coverage is 89.62%.

@@            Coverage Diff             @@
##             main    #1062      +/-   ##
==========================================
+ Coverage   59.52%   60.64%   +1.11%     
==========================================
  Files          85       86       +1     
  Lines        7015     7085      +70     
==========================================
+ Hits         4176     4297     +121     
+ Misses       2622     2568      -54     
- Partials      217      220       +3

Impacted Files	Coverage Δ
rpc/types/utils.go	`0.00% <ø> (ø)`
app/ante/eth.go	`82.67% <82.35%> (-0.02%)`	⬇️
rpc/types/events.go	`90.59% <90.59%> (ø)`
app/ante/handler_options.go	`78.26% <100.00%> (+0.31%)`	⬆️

yihuang · 2022-05-04T10:27:25Z

~~should be replaced by a fix for #1075.~~

go.mod

fedekunze

the approach LGTM. Left some suggestions and comments

go.mod

rpc/types/utils.go

rpc/types/events.go

rpc/backend/utils.go

rpc/namespaces/ethereum/eth/api.go

server/util.go

rpc/namespaces/ethereum/eth/api.go

WIP: evmos#1045 Solution: - emit eth tx hash in ante handler - modify rpc to use it fix ante handler support failed tx in receipt add unit tests need to patch cosmos-sdk to work update cosmos-sdk to v0.45.x release branch fix failed status fix unit tests add unit test cases cleanup dead code Apply suggestions from code review Co-authored-by: Federico Kunze Küllmer <[email protected]> fix lint fix review suggestions fix build fix gas used of failed tx add back the redundant events

yihuang · 2022-05-25T06:41:39Z

I've done all the tests on my side:

cronos integration tests passed.
I upgraded the binary on a production node and checked some json-rpc apis on old blocks, they work too.

rpc/types/events_test.go

rpc/types/events.go

app/ante/eth.go

fedekunze

LGTM, minor suggestions 👍

rpc/types/events.go

Co-authored-by: Federico Kunze Küllmer <[email protected]>

…nto emit-tx-hash

rpc/namespaces/ethereum/eth/api.go

…nto emit-tx-hash

fedekunze

much better 👍 thanks for the descriptions @yihuang

rpc/types/events.go

…ry failed transactions (evmos#1062) * Emit eth tx hash in ante handler to support query failed transactions WIP: evmos#1045 Solution: - emit eth tx hash in ante handler - modify rpc to use it fix ante handler support failed tx in receipt add unit tests need to patch cosmos-sdk to work update cosmos-sdk to v0.45.x release branch fix failed status fix unit tests add unit test cases cleanup dead code Apply suggestions from code review Co-authored-by: Federico Kunze Küllmer <[email protected]> fix lint fix review suggestions fix build fix gas used of failed tx add back the redundant events * fix get tx by index * add unit tests for events * Update rpc/types/events.go Co-authored-by: Federico Kunze Küllmer <[email protected]> * update comments * refactoring * Update rpc/namespaces/ethereum/eth/api.go * fix lint * Apply suggestions from code review Co-authored-by: Federico Kunze Küllmer <[email protected]>

yihuang commented Apr 22, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

yihuang mentioned this pull request May 4, 2022

Store tx hash index separately to get rid of full tendermint tx indexes #1075

Closed

yihuang closed this May 4, 2022

yihuang reopened this May 5, 2022

yihuang force-pushed the emit-tx-hash branch 6 times, most recently from 6e03d89 to 9bdac6b Compare May 16, 2022 12:01

yihuang force-pushed the emit-tx-hash branch 3 times, most recently from b8710f7 to 00c3bf7 Compare May 23, 2022 09:46

yihuang commented May 23, 2022

View reviewed changes

go.mod Outdated Show resolved Hide resolved

yihuang force-pushed the emit-tx-hash branch 2 times, most recently from 8191230 to b6e92ed Compare May 23, 2022 16:40

yihuang marked this pull request as ready for review May 23, 2022 16:41

yihuang requested review from fedekunze, khoslaventures and jolube as code owners May 23, 2022 16:41

fedekunze reviewed May 23, 2022

View reviewed changes

yihuang commented May 23, 2022

View reviewed changes

server/util.go Show resolved Hide resolved

yihuang commented May 23, 2022

View reviewed changes

rpc/namespaces/ethereum/eth/api.go Outdated Show resolved Hide resolved

This was referenced May 24, 2022

Support evm tx in interchain-account host chain #1093

Closed

Problem: failed tx are ignored in json-rpc apis crypto-org-chain/cronos#502

Merged

yihuang force-pushed the emit-tx-hash branch from 9d2533b to d85fe32 Compare May 24, 2022 08:27

fix get tx by index

ddf6424

yihuang force-pushed the emit-tx-hash branch from e51b932 to ddf6424 Compare May 24, 2022 09:55

yihuang requested a review from fedekunze May 25, 2022 06:49

Merge branch 'main' into emit-tx-hash

1be547d

yihuang mentioned this pull request May 30, 2022

Problem: no command to patch missing transactions between v0.7.0 and v0.7.1 crypto-org-chain/cronos#513

Merged

13 tasks

fedekunze suggested changes May 30, 2022

View reviewed changes

rpc/types/events_test.go Outdated Show resolved Hide resolved

rpc/types/events.go Show resolved Hide resolved

app/ante/eth.go Show resolved Hide resolved

yihuang added 2 commits May 31, 2022 09:36

Merge branch 'main' into emit-tx-hash

b0f9ad8

add unit tests for events

b263dcd

yihuang requested a review from fedekunze May 31, 2022 02:41

fedekunze approved these changes May 31, 2022

View reviewed changes

rpc/types/events.go Outdated Show resolved Hide resolved

rpc/types/events.go Outdated Show resolved Hide resolved

rpc/types/events.go Outdated Show resolved Hide resolved

rpc/types/events.go Outdated Show resolved Hide resolved

yihuang and others added 4 commits May 31, 2022 13:51

Update rpc/types/events.go

4bf833c

Co-authored-by: Federico Kunze Küllmer <[email protected]>

update comments

42dc9a5

Merge branch 'emit-tx-hash' of https://github.com/yihuang/ethermint i…

24aafbd

…nto emit-tx-hash

refactoring

c3c0ddf

yihuang commented May 31, 2022

View reviewed changes

rpc/namespaces/ethereum/eth/api.go Outdated Show resolved Hide resolved

yihuang added 4 commits May 31, 2022 14:18

Update rpc/namespaces/ethereum/eth/api.go

2dafde5

Merge branch 'main' into emit-tx-hash

c40493e

fix lint

3e025c0

Merge branch 'emit-tx-hash' of https://github.com/yihuang/ethermint i…

ee39c32

…nto emit-tx-hash

fedekunze approved these changes May 31, 2022

View reviewed changes

rpc/types/events.go Outdated Show resolved Hide resolved

rpc/types/events.go Outdated Show resolved Hide resolved

Apply suggestions from code review

c99ba46

fedekunze enabled auto-merge (squash) May 31, 2022 10:22

fedekunze merged commit 5533bee into evmos:main May 31, 2022

yihuang deleted the emit-tx-hash branch May 31, 2022 10:31

linear bot mentioned this pull request Jun 9, 2022

ante: MinGasPrices AnteHandler decorator evmos/evmos#660

Merged

12 tasks

yihuang mentioned this pull request Jun 15, 2022

tx which failed in deliverTx could deduct fee but can't be found #1045

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Emit eth tx hash in ante handler to support query failed transactions #1062

Emit eth tx hash in ante handler to support query failed transactions #1062

yihuang commented Apr 21, 2022 •

edited

Loading

codecov bot commented Apr 22, 2022 •

edited

Loading

yihuang commented May 4, 2022 •

edited

Loading

fedekunze left a comment

yihuang commented May 25, 2022 •

edited

Loading

fedekunze left a comment

fedekunze left a comment

Emit eth tx hash in ante handler to support query failed transactions #1062

Emit eth tx hash in ante handler to support query failed transactions #1062

Conversation

yihuang commented Apr 21, 2022 • edited Loading

Description

codecov bot commented Apr 22, 2022 • edited Loading

Codecov Report

yihuang commented May 4, 2022 • edited Loading

fedekunze left a comment

Choose a reason for hiding this comment

yihuang commented May 25, 2022 • edited Loading

fedekunze left a comment

Choose a reason for hiding this comment

fedekunze left a comment

Choose a reason for hiding this comment

yihuang commented Apr 21, 2022 •

edited

Loading

codecov bot commented Apr 22, 2022 •

edited

Loading

yihuang commented May 4, 2022 •

edited

Loading

yihuang commented May 25, 2022 •

edited

Loading