Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

imp: migrate JSON for feemarket #1021

Merged
merged 8 commits into from
Mar 30, 2022
Merged

Conversation

fedekunze
Copy link
Contributor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #1021 (b8f4000) into main (285c7c4) will increase coverage by 0.00%.
The diff coverage is 63.26%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1021   +/-   ##
=======================================
  Coverage   59.15%   59.16%           
=======================================
  Files          79       80    +1     
  Lines        6539     6577   +38     
=======================================
+ Hits         3868     3891   +23     
- Misses       2453     2467   +14     
- Partials      218      219    +1     
Impacted Files Coverage Δ
client/testnet.go 0.00% <ø> (ø)
x/feemarket/migrations/v010/migrate.go 62.50% <62.50%> (ø)
x/feemarket/keeper/migrations.go 100.00% <100.00%> (ø)

@fedekunze fedekunze marked this pull request as ready for review March 30, 2022 14:49
@github-actions github-actions bot added C:CLI Type: Tests issues and PR related to tests labels Mar 30, 2022
@fedekunze fedekunze merged commit 3c8a95b into main Mar 30, 2022
@fedekunze fedekunze deleted the fedekunze/migrate-json-feemarket branch March 30, 2022 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C:CLI Type: Tests issues and PR related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants