Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

increase feemarket's consensus version and add migration handler #1002

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Mar 17, 2022

Closes: #1001

Description

Add the migration handler to remove the unused state key.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #1002 (282ec3d) into main (edf4569) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
+ Coverage   59.08%   59.13%   +0.05%     
==========================================
  Files          79       79              
  Lines        6525     6534       +9     
==========================================
+ Hits         3855     3864       +9     
  Misses       2452     2452              
  Partials      218      218              
Impacted Files Coverage Δ
x/feemarket/keeper/migrations.go 100.00% <100.00%> (ø)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Can you add tests for the migration?

x/feemarket/keeper/migrations.go Show resolved Hide resolved
@yihuang
Copy link
Contributor Author

yihuang commented Mar 18, 2022

LGTM, Can you add tests for the migration?

done, added a unit test.

@yihuang yihuang force-pushed the migrate_feemarket branch from 5f361d9 to 282ec3d Compare March 21, 2022 02:19
@fedekunze fedekunze merged commit 93a57bc into evmos:main Mar 21, 2022
@yihuang yihuang deleted the migrate_feemarket branch March 21, 2022 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

there's no migration for the base fee state removal
2 participants