Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: unclear error return when chanid is different #358

Closed
leejw51crypto opened this issue Jul 26, 2021 · 1 comment
Closed

Problem: unclear error return when chanid is different #358

leejw51crypto opened this issue Jul 26, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@leejw51crypto
Copy link
Contributor

leejw51crypto commented Jul 26, 2021 •
edited
Loading

for example, ethermint chanid is 2

and when chain id 1337 is used , instead of 2,
image

error message is too broad
how about returning more detail error message
for example,
"incorrect chanid yours 1337 expected 2"

and return response immediately
@leejw51crypto leejw51crypto added the enhancement New feature or request label Jul 26, 2021
@leejw51crypto leejw51crypto mentioned this issue Jul 26, 2021
Closed
@leejw51crypto
Copy link
Contributor Author

it's metamask issue

yihuang referenced this issue in yihuang/ethermint Sep 25, 2023
@yihuang
Problem: sender address verification is not decoupled from execution (#…
8e9320e 
…358)

* Problem: sender address verification is not decoupled from execution

WIP: #355

Solution:
- to decouple sender address verification from execution, we must first enforce user setting the From field in the msg

* changelog

* fix GetSenderLegacy

* cleanup

* fix unit tests

* reduce overhead of debug log

* lazy init the btree in cache store

because many stores are never touched

* fix mutation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leejw51crypto