Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move isType out of internal and make it a predicate named isSameType #50

Merged
merged 1 commit into from
Feb 4, 2017

Conversation

evilsoft
Copy link
Owner

@evilsoft evilsoft commented Feb 4, 2017

The home stretch


As we come closer to feature lockdown it is time to start cleaning up, optimizing and removing all the duplication (mostly around type assertions).

This PR is the first step in that process. The old and crusty isType just would not live in the new world. So this updates that function to be able to compare types properly in one place. Also, as it is a better interface, it is time to expose it as a real predicate available to the public. So gets a new name and an introduction to the world.

In addition to this move, and cutting over all dependent files, did a couple more 💄 bits:

  • Add both to Arrow and Star on the README
  • Flesh out the predicate signatures on the README
  • Expose some missing predicates to the public API that were missed a couple PRs ago 😧
    • isBoolean
    • isInteger
    • isMonad
    • isSetoid
    • isTraverable

@evilsoft evilsoft added this to the v0.2.3 milestone Feb 4, 2017
@coveralls
Copy link

coveralls commented Feb 4, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ba7b1a6 on isType-pred into 969b105 on master.

@evilsoft
Copy link
Owner Author

evilsoft commented Feb 4, 2017

@evilsoft evilsoft merged commit c2a02a2 into master Feb 4, 2017
@evilsoft evilsoft deleted the isType-pred branch February 4, 2017 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants