Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update traverse and sequence Errors to signal for Apply and not Applicative #212

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

evilsoft
Copy link
Owner

@evilsoft evilsoft commented Feb 15, 2018

The Times are a Changin'

image

Because we are not implementing the fantasy-land methods for the public traverse and sequence methods, we only need to constrain to Apply and not as strict as Applicative as Apply returning functions are all that are needed.

So we should report that 🌽striant properly in our Errors. That, my friends, is all this PR does.

@coveralls
Copy link

coveralls commented Feb 15, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 700ca6a on update-traverse-errors into 36bb58a on master.

@evilsoft
Copy link
Owner Author

image

@evilsoft evilsoft merged commit fa6a199 into master Feb 15, 2018
@evilsoft evilsoft deleted the update-traverse-errors branch February 15, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants