Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use valueOf instead of value #151

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Use valueOf instead of value #151

merged 1 commit into from
Nov 8, 2017

Conversation

evilsoft
Copy link
Owner

@evilsoft evilsoft commented Nov 6, 2017

A bit more Javascript-y

image

We can get a better pointfree function that can work on most types if we go with valueOf over value. That is what this PR addresses. It moves all things that provided a value function to now provide a valueOf function.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e9f3b4b on value-of into 0662911 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 6, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling e9f3b4b on value-of into 0662911 on master.

@coveralls
Copy link

coveralls commented Nov 8, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling c985ada on value-of into 5f13597 on master.

@coveralls
Copy link

coveralls commented Nov 8, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling c985ada on value-of into 5f13597 on master.

@evilsoft
Copy link
Owner Author

evilsoft commented Nov 8, 2017

image

@evilsoft evilsoft merged commit acdf7c4 into master Nov 8, 2017
@evilsoft evilsoft deleted the value-of branch November 8, 2017 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants