Allow prop
and propPath
to accept null
and undefined
as data
#145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the bases covered
As reported in this issue there was a problem when
null
orundefined
is passed as the data toprop
andpropPath
. As both of these functions take anya
as data, they should not throw when passed terminal types. Instead they should map toNothing
.This PR does just that. Also because safe was not really used anywhere except for those (and
safeLift
, but that is a story for another time), moved it out of core. Will deal withsafeLift
with another idea I have surrounding that function.