Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow prop and propPath to accept null and undefined as data #145

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

evilsoft
Copy link
Owner

@evilsoft evilsoft commented Sep 4, 2017

All the bases covered

image

As reported in this issue there was a problem when null or undefined is passed as the data to prop and propPath. As both of these functions take any a as data, they should not throw when passed terminal types. Instead they should map to Nothing.

This PR does just that. Also because safe was not really used anywhere except for those (and safeLift, but that is a story for another time), moved it out of core. Will deal with safeLift with another idea I have surrounding that function.

@coveralls
Copy link

coveralls commented Sep 4, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 7e4294f on fix-prop into a149a0c on master.

1 similar comment
@coveralls
Copy link

coveralls commented Sep 4, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 7e4294f on fix-prop into a149a0c on master.

@coveralls
Copy link

coveralls commented Sep 4, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 61e1d93 on fix-prop into a149a0c on master.

@evilsoft
Copy link
Owner Author

evilsoft commented Sep 5, 2017

image

@evilsoft evilsoft merged commit 99987fe into master Sep 5, 2017
@evilsoft evilsoft deleted the fix-prop branch September 5, 2017 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants