Refactor Color Rounding Logic for Enhanced Flexibility and Consistency #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’ve made some tweaks to our color handling logic. I added a COLOR_FN parameter to the incrementalRoundValue function, which gives us more flexibility when working with different color modes.
|
@ai , please check. thanks |
ai
reviewed
Oct 24, 2024
| @@ -159,29 +159,51 @@ function round2(value: number): number { | |||
| } | |||
|
|
|||
| function round4(value: number): number { | |||
| if (typeof value !== 'number') { | |||
There was a problem hiding this comment.
Can you remove this check? We use TypeScript to check argument type.
This warning take big part of JS bundle and never will be called.
ai
reviewed
Oct 24, 2024
| let precision = i === 0 ? 0 : Math.min(i, maxIterations); | ||
| let roundedValue: LchValue = { | ||
| a: round2(value.a), | ||
| c: round2(value.c), |
There was a problem hiding this comment.
I am not sure, that we should use the same round on each L, C, H on every step.
The problem is that L is 0-100, while C is 0-1. So it better to use different round level for C on every step.
Otherwise, the incrementalRoundValue will keep too many digits after , for L, because algorithm can’t round C anymore.
ai
reviewed
Oct 24, 2024
| return value; | ||
| } | ||
|
|
||
| function isMatch(value: LchValue): boolean { |
There was a problem hiding this comment.
- You check only the fact that sRGB didn’t go to P3. But we need also to check that P3 color will not go to Rec2020. Check the origin algorithm https://github.com/evilmartians/oklch-picker/blob/main/stores/current.ts#L196
- Do we need to replace the origin algorithm? Seems like right now we have 2 different checks and spend resources twice https://github.com/evilmartians/oklch-picker/blob/main/stores/current.ts#L195-L200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve made some tweaks to our color handling logic. I added a COLOR_FN parameter to the incrementalRoundValue function, which gives us more flexibility when working with different color modes.