fix: more verbose error on versions mismatch (#721)

* fix: more verbose error on versions mismatch * fix: add lefthook path
evilmartians · May 17, 2024 · ce8d4f2 · ce8d4f2
1 parent e42043f
commit ce8d4f2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/internal/version/version.go b/internal/version/version.go
@@ -2,6 +2,8 @@ package version
 
 import (
 	"errors"
+	"fmt"
+	"os"
 	"regexp"
 	"strconv"
 )
@@ -17,7 +19,6 @@ var (
 	)
 
 	errIncorrectVersion = errors.New("format of 'min_version' setting is incorrect")
-	errUncovered        = errors.New("required Lefthook version is higher than current")
 )
 
 func Version(verbose bool) string {
@@ -49,6 +50,12 @@ func CheckCovered(targetVersion string) error {
 		return err
 	}
 
+	execPath, err := os.Executable()
+	if err != nil {
+		execPath = "<unknown>"
+	}
+	errUncovered := fmt.Errorf("required lefthook version (%s) is higher than current (%s) at %s", targetVersion, version, execPath)
+
 	switch {
 	case major > tMajor:
 		return nil

diff --git a/testdata/min_version.txt b/testdata/min_version.txt
@@ -1,6 +1,6 @@
 exec git init
 ! exec lefthook run pre-commit
-stdout 'required Lefthook version is higher than current'
+stdout 'required lefthook version \(13.1.1\) is higher than current'
 
 -- lefthook.yml --
 min_version: 13.1.1