Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom callable metric #934

Merged
merged 2 commits into from
Jan 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions src/evidently/metrics/custom_metric.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
from typing import Callable
from typing import List
from typing import Optional
from typing import Union

from pydantic import PrivateAttr

from evidently.base_metric import InputData
from evidently.base_metric import Metric
from evidently.base_metric import MetricResult
from evidently.model.widget import BaseWidgetInfo
from evidently.options.base import AnyOptions
from evidently.renderers.base_renderer import MetricRenderer
from evidently.renderers.base_renderer import default_renderer
from evidently.renderers.html_widgets import CounterData
from evidently.renderers.html_widgets import counter


class CustomCallableMetricResult(MetricResult):
value: float


CustomCallableType = Callable[[InputData], float]


class CustomCallableMetric(Metric[CustomCallableMetricResult]):
func: str
title: Optional[str] = None

_func: Optional[CustomCallableType] = PrivateAttr(None)

def __init__(self, func: Union[CustomCallableType, str], title: str = None, options: AnyOptions = None, **data):
if callable(func):
self._func = func
self.func = f"{func.__module__}.{func.__name__}"
else:
self._func = None
self.func = func
self.title = title
super().__init__(options, **data)

def calculate(self, data: InputData) -> CustomCallableMetricResult:
if self._func is None:
raise ValueError("CustomCallableMetric is not configured with callable func")
return CustomCallableMetricResult(value=self._func(data))


@default_renderer(wrap_type=CustomCallableMetric)
class CustomCallableMetricRenderer(MetricRenderer):
def render_html(self, obj: CustomCallableMetric) -> List[BaseWidgetInfo]:
return [counter(counters=[CounterData.float("", obj.get_result().value, 2)], title=obj.title or "")]
2 changes: 1 addition & 1 deletion tests/multitest/metrics/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def generate_dataset_outcome(m: TestMetric):


def load_test_metrics():
for module in ["classification", "data_integrity", "data_drift", "data_quality", "recsys", "regression"]:
for module in ["classification", "data_integrity", "data_drift", "data_quality", "recsys", "regression", "custom"]:
import_module(f"tests.multitest.metrics.{module}")


Expand Down
26 changes: 26 additions & 0 deletions tests/multitest/metrics/custom.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import pandas as pd

from evidently.base_metric import InputData
from evidently.metrics.custom_metric import CustomCallableMetric
from tests.multitest.conftest import AssertResultFields
from tests.multitest.datasets import TestDataset
from tests.multitest.metrics.conftest import TestMetric
from tests.multitest.metrics.conftest import metric


def custom_func(data: InputData) -> float:
return 0.3


@metric
def custom_callable_metric():
reference_data = current_data = pd.DataFrame({"text": [1, 2, 3]})

return TestMetric(
"custom_callable_metric",
CustomCallableMetric(func=custom_func, title="aaa"),
AssertResultFields({"value": 0.3}),
datasets=[
TestDataset("custom_callable_metric_data", current=current_data, reference=reference_data, tags=[]),
],
)