Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better json encoder to collector #868

Merged
merged 1 commit into from
Nov 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/evidently/collector/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from evidently.collector.storage import LogEvent
from evidently.telemetry import DO_NOT_TRACK_ENV
from evidently.telemetry import event_logger
from evidently.ui.utils import NumpyJsonResponse
from evidently.ui.utils import authenticated
from evidently.ui.utils import set_secret

Expand Down Expand Up @@ -49,7 +50,7 @@ async def lifespan(app: FastAPI):


app = FastAPI(lifespan=lifespan)
collector_write_router = APIRouter(dependencies=[Depends(authenticated)])
collector_write_router = APIRouter(dependencies=[Depends(authenticated)], default_response_class=NumpyJsonResponse)


@collector_write_router.post("/{id}")
Expand Down
9 changes: 9 additions & 0 deletions src/evidently/ui/utils.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import json
import os
import urllib.parse
from typing import Any
from typing import Optional

import requests
from fastapi import Header
from fastapi import HTTPException
from starlette.responses import JSONResponse
from typing_extensions import Annotated

from evidently._pydantic_compat import parse_obj_as
Expand Down Expand Up @@ -52,3 +54,10 @@ def _request(
if response_model is not None:
return parse_obj_as(response_model, response.json())
return response


class NumpyJsonResponse(JSONResponse):
def render(self, content: Any) -> bytes:
return json.dumps(
content, ensure_ascii=False, allow_nan=True, indent=None, separators=(",", ":"), cls=NumpyEncoder
).encode("utf-8")