refactor: Rewrote verify method of RemoteWorkspace #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mou
force-pushed
the
refactor/remote-workspace-verify-to-detect-evidently
branch
from
e430043
to
38e4872
Compare
Previously this method does not check much except HTTP status Closes: #826
mou
force-pushed
the
refactor/remote-workspace-verify-to-detect-evidently
branch
from
38e4872
to
3746304
Compare
emeli-dral
deleted the
refactor/remote-workspace-verify-to-detect-evidently
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this method did not check much except HTTP status. This change allows us to properly detect Evidently and also avoid using endpoints with irregular trailing slash.
Closes: #826