Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove correlation from presets. #1219

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Remove correlation from presets. #1219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c900740
Remove correlation from presets.
Liraim Jul 24, 2024
3301f32
Fix tests.
Liraim Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/evidently/metric_preset/data_quality.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

from evidently.metric_preset.metric_preset import MetricPreset
from evidently.metrics import ColumnSummaryMetric
from evidently.metrics import DatasetCorrelationsMetric
from evidently.metrics import DatasetSummaryMetric
from evidently.metrics.base_metric import generate_column_metrics
from evidently.metrics.data_integrity.dataset_missing_values_metric import DatasetMissingValuesMetric
Expand Down Expand Up @@ -36,5 +35,4 @@ def generate_metrics(self, data_definition: DataDefinition, additional_data: Opt
DatasetSummaryMetric(),
generate_column_metrics(ColumnSummaryMetric, columns=self.columns, skip_id_column=True),
DatasetMissingValuesMetric(),
DatasetCorrelationsMetric(),
]
2 changes: 0 additions & 2 deletions src/evidently/test_preset/data_quality.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from evidently.test_preset.test_preset import TestPreset
from evidently.tests import TestAllColumnsMostCommonValueShare
from evidently.tests import TestAllColumnsShareOfMissingValues
from evidently.tests import TestHighlyCorrelatedColumns
from evidently.tests import TestNumberOfConstantColumns
from evidently.tests import TestNumberOfDuplicatedColumns
from evidently.tests import TestNumberOfDuplicatedRows
Expand Down Expand Up @@ -42,5 +41,4 @@ def generate_tests(self, data_definition: DataDefinition, additional_data: Optio
TestNumberOfConstantColumns(),
TestNumberOfDuplicatedColumns(),
TestNumberOfDuplicatedRows(),
TestHighlyCorrelatedColumns(),
]
2 changes: 1 addition & 1 deletion tests/test_preset/test_data_quality.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ def test_data_quality_preset():

data_quality_suite.run(current_data=test_current_dataset, reference_data=test_reference_dataset)
assert not data_quality_suite
assert len(data_quality_suite.as_dict()["tests"]) == 12
assert len(data_quality_suite.as_dict()["tests"]) == 11
Loading