Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add datasets to cloud workspace #1192

Merged
merged 4 commits into from
Jul 10, 2024
Merged

add datasets to cloud workspace #1192

merged 4 commits into from
Jul 10, 2024

Conversation

mike0sv
Copy link
Collaborator

@mike0sv mike0sv commented Jul 8, 2024

No description provided.

response = self._request(
"/api/datasets/",
"POST",
body={"name": name, "description": description, "file": file},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

column_mapping missing

Copy link
Collaborator

@svetleo-evidently svetleo-evidently Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean for UI we have a separate handler patch datasets. For sdk maybe we want to have an opportunity to set columnMapping right from add_dataset. Feel free to change api a little bit for that

@mike0sv mike0sv merged commit fdd12d2 into main Jul 10, 2024
25 checks passed
@mike0sv mike0sv deleted the feature/ws_dataset_api branch July 10, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants