Fixes bug where DataTable component throws error when underlying columns in data change #2827
+301
−293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantaks
temporarily deployed
to
Approval required to run action on external PR
GitHub Actions
Inactive
jantaks
temporarily deployed
to
Approval required to run action on external PR
GitHub Actions
Inactive
|
Looks like some of the DataTable stories are encountering an error when building Storybook |
jantaks
temporarily deployed
to
Approval required to run action on external PR
GitHub Actions
Inactive
jantaks
temporarily deployed
to
Approval required to run action on external PR
GitHub Actions
Inactive
ItsMeBrianD
temporarily deployed
to
Approval required to run action on external PR
GitHub Actions
Inactive
ItsMeBrianD
temporarily deployed
to
Approval required to run action on external PR
GitHub Actions
Inactive
ItsMeBrianD
approved these changes
Nov 25, 2024
zachstence
requested a deployment
to
Approval required to run action on external PR
GitHub Actions
Waiting
zachstence
requested a deployment
to
Approval required to run action on external PR
GitHub Actions
Waiting
zachstence
temporarily deployed
to
Approval required to run action on external PR
GitHub Actions
Inactive
zachstence
temporarily deployed
to
Approval required to run action on external PR
GitHub Actions
Inactive
zachstence
requested changes
Nov 25, 2024
There was a problem hiding this comment.
Hey @jantaks, seems like there's still an issue with the DataTable. Our base-path and prerender E2E tests are failing. I pulled down your branch and tried to run e2e/base-path and when I go to the /table-row-links page, everything freezes. Seems like there's some infinite reactivity update happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
I wanted to create a DataTable for the result of a PIVOT operation when i found that this component could not deal with the underlying column IDs changing.
The issue is caused by 2 pieces of state (columns and columSummary) that are not updated in the correct sequence during the rendering process.
See storybook: /story/viz-datatable--reactive-datatable
Before:
After:
Checklist