Initial renaming for GDAL3 move. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you see this error locally? And GDAL.jl is checked out to the right branch and built and its tests pass? |
yeesian
reviewed
Aug 16, 2019
src/utils.jl
Outdated
| @@ -23,7 +23,7 @@ const GMF = Dict( | |||
| function mask_flags(flags::Int32) | |||
| (f.first for f in GMF if (flags & f.second) == f.second) | |||
| end | |||
| mask_flags(band::ArchGDAL.RasterBand) = mask_flags(GDAL.C.GDALGetMaskFlags(Ptr{Nothing}(band.ptr))) | |||
| mask_flags(band::ArchGDAL.IRasterBand) = mask_flags(GDAL.gdalgetmaskflags(Ptr{Nothing}(band.ptr))) | |||
There was a problem hiding this comment.
I think ArchGDAL.AbstractRasterBand should work fine here?
Yeah. Weird thing is, if I run a similar command in the REPL, everything works. But not when running tests. I'm going to temporarily commit my Manifest.toml and see whether the CI has the same issues. edit: same thing happens on Travis. |
4 tasks
as both GDAL and ArchGDAL have released new versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting to changes in:
At the moment running into: