Legislature tabs #15426
Closed
Legislature tabs #15426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octopusinvitro
force-pushed
the
legislature-tabs
branch
from
999e0ad to
ce64d8d
Compare
30 tasks
12 tasks
octopusinvitro
force-pushed
the
legislature-tabs
branch
from
ce64d8d to
f19c3d2
Compare
Makes it easier to move from, for example, a country's lower to upper chamber. Will also help people navigate once executive branch is included (#13297).
Also includes some fixes for various term_table page elements that were causing horizontal scrolling on narrow screens.
octopusinvitro
force-pushed
the
legislature-tabs
branch
from
f19c3d2 to
fd1e2c5
Compare
|
tabs look fine to me, it's a good solution, thanks for implementing it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was superseeded by #15451
What does this do?
This PR rescues the work of @zarino adding a tab component in PR #13598
Why was this needed?
After merging the house/download page, it was clear that either a reword of the bottom of that page was needed (#15259) or either to go for the tab component integration directly (#15240). The latter was chosen and so this PR integrates Zarino's work in #13598 to the term table page instead.
Relevant Issue(s)
This is part of issue #15259 regarding the reword the house download page, which was part of issue #15240 to link between legislature download pages in the same country. It is also the last point in the first section of the workflow described in todo list #15256
Implementation notes
I took the two first commits made by Zarino, added the changes from his fixup commit, and updated the variables used in the template to use the page object passed to the template. Then I added his two commits to this branch. Finally, I made my changes on top of those two commits.
Adds:
term_table.erbtemplate and related styles.Screenshots
Country with more than one legislature:
Country with only one legislature:
Notes to Reviewer
If the tab component is added to more pages, it's probably better to extract it to it's own erb partial.
But for now, since this is the first page where the component is integrated, I decided to leave it in the template.
Some candidates for tab component integration:
Notes to Merger
This PR should finish section 1 of #15256 🎉 🎈