Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executive memberships #24

Closed
tmtmtmtm opened this issue Apr 21, 2015 · 4 comments
Closed

Executive memberships #24

tmtmtmtm opened this issue Apr 21, 2015 · 4 comments

Comments

@tmtmtmtm
Copy link
Contributor

Display Executive-level memberships per Person, and per-Government, including pivoting to a view of who else has held that same position over time.

@tmtmtmtm
Copy link
Contributor Author

Depends on everypolitician/everypolitician#178

@chrismytton
Copy link
Contributor

chrismytton commented Feb 17, 2017

Have done a prototype of this in #13600.

The prototype was useful as a guiding light, but I think for the next stage we probably want to throw that away and do a fresh version using TDD.

@chrismytton
Copy link
Contributor

TODO

  • Add classes to the lib/everypolitician_extensions.rb file for interacting with position data. Prototype of this in [WIP] Everypolitician::Positions prototype #15608.
    • Everypolitician::Position which represents an individual position held
    • Everypolitician::Positions for filtering and interacting with positions data
      • Should be able to filter by type (we just want to show the cabinet positions initially)
      • Should be able to filter by term, i.e. "give me all the positions between these two dates"
  • Add Everypolitician::UnstablePositionCSV class for getting the position data out of the unstable/positions.csv file. Add a way to get cabinet membership data for a person #15606
    • This can then be replaced with another class when we decide where the position data will live.
  • Allow Everypolitician::Popolo::Person instances to access the position data for the person

@tmtmtmtm
Copy link
Contributor Author

superseded by everypolitician/everypolitician#651

@ghost ghost removed the 3 - WIP label Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants