Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to get cabinet membership data for a person #15606

Open
chrismytton opened this issue Feb 17, 2017 · 1 comment
Open

Add a way to get cabinet membership data for a person #15606

chrismytton opened this issue Feb 17, 2017 · 1 comment
Labels

Comments

@chrismytton
Copy link
Contributor

chrismytton commented Feb 17, 2017

Problem

As part of #24 we'll need to get access to the unstable/positions.csv file in the legislature's directory in ep-data, at least until we move that data into the Popolo.

Proposed Solution

The code I wrote for the prototype does the job, so possibly just a case of pulling this into lib/everypolitician_extensions.rb and tidying it up a bit.

We should also have a Struct that represents each individual position object, so we don't have to use [] to access properties of a position.

Acceptance Criteria

I should be able to access the positions for a legislature in a Page::TermTable instance by calling house.positions.

I should be able to access cabinet memberships using the code in the README that was added in #15609.

Related Issues

@chrismytton
Copy link
Contributor Author

I've done a prototype of this in #15608 but it's currently blocked because the test fixtures have an old version of the position CSVs which is missing the type column. I've opened #15607 to track that.

@ghost ghost assigned chrismytton Feb 21, 2017
@ghost ghost added the 3 - WIP label Feb 21, 2017
@chrismytton chrismytton changed the title Add method for accessing legislature position data Add a way to get cabinet membership data for a person Feb 22, 2017
@chrismytton chrismytton removed their assignment Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant