Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with Objects in templates, not JSON #14844

Closed
tmtmtmtm opened this issue Aug 22, 2016 · 1 comment
Closed

Work with Objects in templates, not JSON #14844

tmtmtmtm opened this issue Aug 22, 2016 · 1 comment
Assignees

Comments

@tmtmtmtm
Copy link
Contributor

tmtmtmtm commented Aug 22, 2016

Problem

In the templates, we're working with raw JSON a lot. Really we should ensuring that we're properly dogfooding everypolitician-ruby and everypolitician-popolo and operating on objects from those, rather than on raw data.

Proposed Solution

Switch everything to using the functionality that already exists in everypolitician-ruby and everypolitician-popolo, World.rb etc).

Where that functionality is missing, either add it to those libraries, or, if it's not exactly clear how it should work there, or whether it's universally useful, add it initially to everypolitician_extensions.rb instead.

Acceptance Criteria

fgrep \[: **/*.erb | wc -l should return 0 (currently 100).

@tmtmtmtm
Copy link
Contributor Author

tmtmtmtm commented Oct 2, 2016

fgrep \[: **/*.erb | wc -l
       0

@tmtmtmtm tmtmtmtm closed this as completed Oct 2, 2016
@tmtmtmtm tmtmtmtm removed the 3 - WIP label Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants