Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass Popolo to Wikidata page #14839

Closed
tmtmtmtm opened this issue Aug 22, 2016 · 1 comment
Closed

Don't pass Popolo to Wikidata page #14839

tmtmtmtm opened this issue Aug 22, 2016 · 1 comment
Assignees
@ondenman
Labels
refactoring

Comments

@tmtmtmtm
Copy link
Contributor

tmtmtmtm commented Aug 22, 2016 •
edited
Loading

Generally we shouldn't be passing the entire Popolo object into templates, but only the parts needed for the page.

Clean this up for house_wikidata, passing lists of people_with_wikidata and people_without_wikidata instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ondenman ondenman

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmtmtmtm @ondenman