refactor: Newtonsoft dependency removed - close #12 #22
Conversation
|
Thanks for the PR! @cer, is there anything that needs to be done (perhaps a CLA or something) before we can accept this PR? |
@cetindogu Thanks for creating the PR. Please could you sign a CLA: https://chrisrichardson.net/legal/CRCINC_Individual_CLA.pdf or https://chrisrichardson.net/legal/CRCINC_Corporate_CLA.pdf |
| // Make property name matching case-insensitive during deserialization | ||
| PropertyNameCaseInsensitive = true |
There was a problem hiding this comment.
I'm unsure as to whether this should be case sensitive or insensitive. The original intent of the .NET port was to match the behavior of the Java implementation, so perhaps we should try to match what it does by default.
@cer: Do you know if the Java eventuate-tram is case-sensitive or insensitive for property names during deserialization?
There was a problem hiding this comment.
It's case sensitive although it is configurable: https://fasterxml.github.io/jackson-databind/javadoc/2.5/com/fasterxml/jackson/databind/MapperFeature.html#ACCEPT_CASE_INSENSITIVE_PROPERTIES
.net has build in serialization and deserilization class "System.Text.Json"
so Newtonsoft removed.
this Pull request closes #12