Add sanitization #16
Open
Add sanitization #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 22, 2019 12:57
mnelson4
suggested changes
Oct 23, 2019
sethshoultes
commented
Oct 23, 2019
|
@mnelson4 thanks! Yes, it a lot of code. I added all of your suggestions. It looks like @Pebblo has a question on one your suggestions here: #16 (comment) |
mnelson4
suggested changes
Oct 24, 2019
added 3 commits
October 24, 2019 05:49
mnelson4
approved these changes
Dec 5, 2019
| $staff_meta['phone'] = sanitize_text_field($_REQUEST['phone']); | ||
| $staff_meta['twitter'] = sanitize_text_field($_REQUEST['twitter']); | ||
| $staff_meta['image'] = sanitize_text_field($_REQUEST['image']); | ||
| $staff_meta['website'] = sanitize_text_field($_REQUEST['website']); |
There was a problem hiding this comment.
is this a url? if so esc_url_raw() would be better
| $staff_meta['website'] = $_REQUEST['website']; | ||
| $staff_meta['phone'] = sanitize_text_field($_REQUEST['phone']); | ||
| $staff_meta['twitter'] = sanitize_text_field($_REQUEST['twitter']); | ||
| $staff_meta['image'] = sanitize_text_field($_REQUEST['image']); |
There was a problem hiding this comment.
is this a url too? if so esc_url_raw() would be better
Comment on lines
8
to
9
| $staff_meta['image'] = sanitize_text_field($_REQUEST['image']); | ||
| $staff_meta['website'] = sanitize_text_field($_REQUEST['website']); |
mnelson4
suggested changes
Dec 5, 2019
mnelson4
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sanitization throughout the plugin.