[MINOR] Ensure support for Redis 6 with ACLs and TLS #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nickwilliams-eventbrite
commented
Mar 13, 2020
•
nickwilliams-eventbrite
commented
- Update functional tests to use Redis 5 and 6 instead of Redis 4 and 5.
- Update Redis 6 Sentinel tests to use ACLs (authentication) and TLSv1.2 (TLSv1.3 cannot be supported on Ubuntu 16.04).
- Add a few more functional tests.
- This proves that:
- PySOA can use Redis 6 without ACL and TLS
- PySOA can use Redis 6 with ACL
- PySOA can use Redis 6 with TLS with unprotected Sentinel
- PySOA can use Redis 6 with TLS with Sentinel with TLS
- Created SentinelManagedConnection needs a SSLSentinelManagedConnection to complement SSLConnection redis/redis-py#1306.
- Created Sentinel should support user-password like replicas do with ACL enhancements redis/redis#6986.
- Created antirez/redis#6985.
vartec
approved these changes
Mar 13, 2020
- Update functional tests to use Redis 5 and 6 instead of Redis 4 and 5. - Update Redis 6 Sentinel tests to use ACLs (authentication) and TLSv1.2 (TLSv1.3 cannot be supported on Ubuntu 16.04). - Add a few more functional tests. - This proves that: - PySOA can use Redis 6 without ACL and TLS - PySOA can use Redis 6 with ACL - PySOA can use Redis 6 with TLS with unprotected Sentinel - PySOA can use Redis 6 with TLS with Sentinel with TLS - Created redis/redis-py#1306. - Created redis/redis#6986. - Created antirez/redis#6985.
nickwilliams-eventbrite
force-pushed
the
redis-6
branch
from
5339dc7
to
d6760f3
Compare
sethbrite
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.