Add missing StringSetter for the script provider #17314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhuss
force-pushed
the
pr/script-setter
branch
from
ebe3498
to
d7d1027
Compare
rhuss
force-pushed
the
pr/script-setter
branch
from
d7d1027
to
7a70c33
Compare
|
Great, thank you! |
mabunixda
added a commit
to mabunixda/evcc
that referenced
this pull request
Nov 22, 2024
* master: (58 commits) Add Huawei EMMA (evcc-io#17338) Config UI: device value formatting (evcc-io#17258) chore: upgrade npm dependencies (evcc-io#17344) chore: fix template Easee: fix PhaseGetter returning used, not configured, phases (evcc-io#17326) chore: refactor MacOS: add gobuildid Script: simplify setters Tariffs: formula, charges, tax > advanced fields (evcc-io#17301) Push: add custom messenger (BC) (evcc-io#17211) Script: add missing string setter (evcc-io#17314) Sofar: fix docs (evcc-io#17324) Polestar: skip test Polestar: fix authentication (evcc-io#17276) chore: fix line breaks chore: fix quotes Add Tessie (evcc-io#17274) PUN: update api endpoint (evcc-io#17270) Revert "EM24: add pv usage & fix energy (evcc-io#17173)" Enphase: fix soc ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess it was just forgotten to add it if I understand the pattern right.
It also helps make #17211 work.