Fix resetRetrieveHandlers to reset retrieveSourceMap and retrieveFile functions
#235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eFile` functions The `handlerExec` function produces functions that are using original `retrieveFileHandlers`/`retrieveMapHandlers` references, so because the array variables are re-assigned in the `resetRetrieveHandlers` function, `retrieveSourceMap` and `retrieveFile` need to be re-created to point them to correct instances of `retrieveFileHandlers`/`retrieveMapHandlers`. This fixes: jestjs/jest#6424 jestjs/jest#7402
|
LGTM, thanks! |
|
Published as 0.5.11, please report back if it works or not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
handlerExecfunction produces functions that are using originalretrieveFileHandlers/retrieveMapHandlersreferences, so because the array variables are re-assigned in theresetRetrieveHandlersfunction,retrieveSourceMapandretrieveFileneed to be re-created to point them to correct instances ofretrieveFileHandlers/retrieveMapHandlers.This fixes:
jestjs/jest#6424
jestjs/jest#7402