-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: alias
doesnt match against the whole import (but replaces partials too)
#2963
Comments
mhsdesign
added a commit
to neos/neos-ui
that referenced
this issue
Mar 2, 2023
Thanks for the report. This is actually a determinism issue as esbuild stops when it encounters the first match instead of checking all of them and taking the longest match. So this is definitely a bug with esbuild. |
Thank you for fixing it and your efforts ❤️ |
mhsdesign
added a commit
to neos/neos-ui
that referenced
this issue
Mar 27, 2023
This reverts commit 9c547cc. As it was fixed via: v0.17.11 in esbuild: https://github.com/evanw/esbuild/releases/tag/v0.17.11 see evanw/esbuild#2963
markusguenther
pushed a commit
to neos/neos-ui
that referenced
this issue
Apr 11, 2023
This reverts commit 9c547cc. As it was fixed via: v0.17.11 in esbuild: https://github.com/evanw/esbuild/releases/tag/v0.17.11 see evanw/esbuild#2963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in webpack (4) i was able to sucessfully use their "resolve" feature to archive the following: mapping my imports to a shim.
i personally would expect that this map would also work with the esbuild alias feature.
But my assumption is wrong, i thought
redux-saga
would be handled like this/^redux-saga\/?$/
but the import is also replaced for this case:will become
(which i dindt anticipate for now)
it seems my first alias
redux-saga/effects
is not used butredux-saga
will take effect and theeffects
subfolder/file is appended ...maybe its a feature though ^^ i mean i could just adjust my code, but wanted to ask if this behaviour is intended.
The text was updated successfully, but these errors were encountered: