Skip to content

Commit

Permalink
cli: clean up extra return value code
Browse files Browse the repository at this point in the history
  • Loading branch information
evanw committed Feb 2, 2022
1 parent eba56ee commit fc45394
Show file tree
Hide file tree
Showing 2 changed files with 67 additions and 60 deletions.
4 changes: 2 additions & 2 deletions pkg/cli/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func Run(osArgs []string) int {
//
func ParseBuildOptions(osArgs []string) (options api.BuildOptions, err error) {
options = newBuildOptions()
errWithNote, _ := parseOptionsImpl(osArgs, &options, nil, kindExternal)
_, errWithNote := parseOptionsImpl(osArgs, &options, nil, kindExternal)
if errWithNote != nil {
err = errors.New(errWithNote.Text)
}
Expand All @@ -71,7 +71,7 @@ func ParseBuildOptions(osArgs []string) (options api.BuildOptions, err error) {
//
func ParseTransformOptions(osArgs []string) (options api.TransformOptions, err error) {
options = newTransformOptions()
errWithNote, _ := parseOptionsImpl(osArgs, nil, &options, kindExternal)
_, errWithNote := parseOptionsImpl(osArgs, nil, &options, kindExternal)
if errWithNote != nil {
err = errors.New(errWithNote.Text)
}
Expand Down
Loading

0 comments on commit fc45394

Please sign in to comment.