fix: negative number is illegal attribute for object (#2273)

evanw · May 27, 2022 · f798118 · f798118
1 parent a5bad10
commit f798118
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/js_parser/js_parser.go b/internal/js_parser/js_parser.go
@@ -13183,7 +13183,7 @@ func (p *parser) visitExprInOut(expr js_ast.Expr, in exprIn) (js_ast.Expr, exprO
 			// "{ '123': 4 }" => "{ 123: 4 }" (this is done late to allow "'123'" to be mangled)
 			if p.options.minifySyntax {
 				if str, ok := property.Key.Data.(*js_ast.EString); ok {
-					if numberValue, ok := stringToEquivalentNumberValue(str.Value); ok {
+					if numberValue, ok := stringToEquivalentNumberValue(str.Value); numberValue >= 0 && ok {
 						property.Key.Data = &js_ast.ENumber{Value: numberValue}
 					}
 				}

diff --git a/internal/js_parser/js_parser_test.go b/internal/js_parser/js_parser_test.go
@@ -1222,15 +1222,15 @@ func TestObject(t *testing.T) {
 	// Check the string-to-int optimization
 	expectPrintedMangle(t, "x = { '0': y }", "x = { 0: y };\n")
 	expectPrintedMangle(t, "x = { '123': y }", "x = { 123: y };\n")
-	expectPrintedMangle(t, "x = { '-123': y }", "x = { -123: y };\n")
+	expectPrintedMangle(t, "x = { '-123': y }", "x = { \"-123\": y };\n")
 	expectPrintedMangle(t, "x = { '-0': y }", "x = { \"-0\": y };\n")
 	expectPrintedMangle(t, "x = { '01': y }", "x = { \"01\": y };\n")
 	expectPrintedMangle(t, "x = { '-01': y }", "x = { \"-01\": y };\n")
 	expectPrintedMangle(t, "x = { '0x1': y }", "x = { \"0x1\": y };\n")
 	expectPrintedMangle(t, "x = { '-0x1': y }", "x = { \"-0x1\": y };\n")
 	expectPrintedMangle(t, "x = { '2147483647': y }", "x = { 2147483647: y };\n")
 	expectPrintedMangle(t, "x = { '2147483648': y }", "x = { \"2147483648\": y };\n")
-	expectPrintedMangle(t, "x = { '-2147483648': y }", "x = { -2147483648: y };\n")
+	expectPrintedMangle(t, "x = { '-2147483648': y }", "x = { \"-2147483648\": y };\n")
 	expectPrintedMangle(t, "x = { '-2147483649': y }", "x = { \"-2147483649\": y };\n")
 }