fix a regexp parsing bug due to a stray break

evanw · May 27, 2022 · cfb1b07 · cfb1b07
1 parent 14d9de5
commit cfb1b07
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/internal/js_parser/js_parser.go b/internal/js_parser/js_parser.go
@@ -11571,7 +11571,6 @@ pattern:
 				case '\\':
 					i++ // Skip the escaped character
 				}
-				break
 			}
 
 		case '(':

diff --git a/internal/js_parser/js_parser_test.go b/internal/js_parser/js_parser_test.go
@@ -577,13 +577,17 @@ func TestAwait(t *testing.T) {
 }
 
 func TestRegExp(t *testing.T) {
+	expectPrinted(t, "/x/d", "/x/d;\n")
 	expectPrinted(t, "/x/g", "/x/g;\n")
 	expectPrinted(t, "/x/i", "/x/i;\n")
 	expectPrinted(t, "/x/m", "/x/m;\n")
 	expectPrinted(t, "/x/s", "/x/s;\n")
 	expectPrinted(t, "/x/u", "/x/u;\n")
 	expectPrinted(t, "/x/y", "/x/y;\n")
 
+	expectParseError(t, "/)/", "<stdin>: ERROR: Unexpected \")\" in regular expression\n")
+	expectPrinted(t, "/[\\])]/", "/[\\])]/;\n")
+
 	expectParseError(t, "/x/msuygig",
 		`<stdin>: ERROR: Duplicate flag "g" in regular expression
 <stdin>: NOTE: The first "g" was here:
-Original file line number
+Diff line change
@@ Expand Up / @@ -11571,7 +11571,6 @@ pattern: @@
     				case '\\':
     					i++ // Skip the escaped character
     				}
-    				break
     			}
     		case '(':
@@ Expand Down @@