fix(bundle): omit enum comments if name contains */ in bundle mode (#…

…2371)
evanw · Jul 6, 2022 · 46d352e · 46d352e
1 parent 71be8bc
commit 46d352e
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 1 deletion.
diff --git a/internal/bundler/bundler_ts_test.go b/internal/bundler/bundler_ts_test.go
@@ -223,6 +223,28 @@ func TestTSDeclareConstEnum(t *testing.T) {
 	})
 }
 
+func TestConstEnumComments(t *testing.T) {
+	ts_suite.expectBundled(t, bundled{
+		files: map[string]string{
+			"/bar.ts": `
+			export const enum PRCD {
+				"*/%" = 14,
+			}
+			`,
+			"/foo.ts": `
+			import { PRCD } from "./bar";
+
+			console.log(PRCD["*/%"]);
+			`,
+		},
+		entryPaths: []string{"/foo.ts"},
+		options: config.Options{
+			Mode:          config.ModeBundle,
+			AbsOutputFile: "/out.js",
+		},
+	})
+}
+
 func TestTSImportEmptyNamespace(t *testing.T) {
 	ts_suite.expectBundled(t, bundled{
 		files: map[string]string{

diff --git a/internal/bundler/snapshots/snapshots_ts.txt b/internal/bundler/snapshots/snapshots_ts.txt
@@ -1,3 +1,9 @@
+TestConstEnumComments
+---------- /out.js ----------
+// foo.ts
+console.log(14);
+
+================================================================================
 TestExportTypeIssue379
 ---------- /out.js ----------
 // a.ts

diff --git a/internal/js_printer/js_printer.go b/internal/js_printer/js_printer.go
@@ -2001,7 +2001,7 @@ func (p *printer) printExpr(expr js_ast.Expr, level js_ast.L, flags printExprFla
 								} else {
 									p.printNumber(value.Number, level)
 								}
-								if !p.options.MinifyWhitespace && !p.options.MinifyIdentifiers {
+								if !p.options.MinifyWhitespace && !p.options.MinifyIdentifiers && !strings.Contains(name, "*/") {
 									p.print(" /* ")
 									p.print(name)
 									p.print(" */")