Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default export in favor of named exports #130

Merged
merged 1 commit into from
Nov 27, 2021
Merged

Conversation

evansiroky
Copy link
Owner

Fixes #129

microbundle is not happy with the mixing of default and named exports. It seems the easiest thing to do here is make the default export a named export.

This is probably a breaking change from v7.0.0, but since it was released not long ago and not really working all that well anyways, I'm just calling this a fix and assuming this named export thing should've been a breaking change that landed in v7.0.0.

This is probably a violation of SEMVER in a strict sense, so I apologize to anyone who already made workarounds for what was in v7.0.0.

Fixes #129

microbundle is not happy with the mixing of default and named exports. It seems the easiest thing to do here is make the default export a named export.

This is probably a breaking change from v7.0.0, but since it was released not long ago and not really working all that well anyways, I'm just calling this a fix and assuming this named export thing should've been a breaking change that landed in v7.0.0.

This is probably a violation of SEMVER in a strict sense, so I apologize to anyone who already made workarounds for what was in v7.0.0.
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2021

Codecov Report

Merging #130 (adb1f21) into master (4f0bf4f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   82.69%   82.69%           
=======================================
  Files           4        4           
  Lines         312      312           
  Branches       59       59           
=======================================
  Hits          258      258           
  Misses         34       34           
  Partials       20       20           
Impacted Files Coverage Δ
src/find.ts 78.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0bf4f...adb1f21. Read the comment docs.

@evansiroky evansiroky merged commit afa29d3 into master Nov 27, 2021
@evansiroky
Copy link
Owner Author

🎉 This PR is included in version 7.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v7.0.0 esm import problem
2 participants