Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduces calc overhead of suffix helper method #128

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

jtbg
Copy link
Contributor

@jtbg jtbg commented Mar 30, 2023

if only there were some sort of tool we could use to measure the performance gains

Copy link
Contributor

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is nice.

could you squash your commits?
(disclaimer: I'm not a maintainer)

@jtbg jtbg force-pushed the scale_helper_optimzation branch from 067fe3a to 706af23 Compare March 30, 2023 15:36
@jtbg
Copy link
Contributor Author

jtbg commented Mar 30, 2023

thanks for reminding me @kbrock

@kbrock
Copy link
Contributor

kbrock commented Mar 30, 2023

Aah, I was confused because you commented on a commit that had changes not here.
This PR is just picking off the obvious win. 👍

@kbrock
Copy link
Contributor

kbrock commented Mar 30, 2023

hmm... could you remove the merge commit, and rebase this onto master?

(sorry if you already know this stuff)

git fetch upstream
git checkout scale_helper_optimization
git branch scale_helper_optimization_bak # just in case
git reset --hard HEAD~1 # drop the merge commit
git rebase upstream/master

git diff scale_helper_optimization_bak # should be the same
git log -3 # this branch should just have a single commit

@jtbg
Copy link
Contributor Author

jtbg commented Mar 30, 2023

WHat does git branch scale_helper_optimization_bak do here? I've never seen that before

edit: oh I get it, that is just creating a new, identical branch

whitespace commits don't count

s/caclulations/calculations
@jtbg jtbg force-pushed the scale_helper_optimzation branch from 6e7a6f3 to 65ba536 Compare March 30, 2023 16:58
@jtbg
Copy link
Contributor Author

jtbg commented Mar 30, 2023

This is why I always get @emgreen33 to untangle my git spaghetti for me 🤣
Thanks for the help!

@@ -1,5 +1,5 @@
module Benchmark
# Perform caclulations on Timing results.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it for the lulz!

@nateberkopec nateberkopec merged commit 3316f6d into evanphx:master Mar 31, 2023
@jtbg jtbg deleted the scale_helper_optimzation branch March 31, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants