-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduces calc overhead of suffix helper method #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is nice.
could you squash your commits?
(disclaimer: I'm not a maintainer)
067fe3a
to
706af23
Compare
thanks for reminding me @kbrock |
Aah, I was confused because you commented on a commit that had changes not here. |
hmm... could you remove the merge commit, and rebase this onto master? (sorry if you already know this stuff)
|
WHat does edit: oh I get it, that is just creating a new, identical branch |
whitespace commits don't count s/caclulations/calculations
6e7a6f3
to
65ba536
Compare
This is why I always get @emgreen33 to untangle my git spaghetti for me 🤣 |
@@ -1,5 +1,5 @@ | |||
module Benchmark | |||
# Perform caclulations on Timing results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it for the lulz!
if only there were some sort of tool we could use to measure the performance gains