fs: close file if fstat() fails in readFile()

Currently, if fstat() fails in readFile(), the callback is invoked without closing the file. This commit closes the file before calling back. Closes nodejs#7697
evanlucas · May 29, 2014 · c7b0203 · c7b0203
1 parent 57c5655
commit c7b0203
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/fs.js b/lib/fs.js
@@ -229,7 +229,12 @@ fs.readFile = function(path, options, callback_) {
     fd = fd_;
 
     fs.fstat(fd, function(er, st) {
-      if (er) return callback(er);
+      if (er) {
+        return fs.close(fd, function() {
+          callback(er);
+        });
+      }
+
       size = st.size;
       if (size === 0) {
         // the kernel lies about many files.