fix: Simplify esplora cli example #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..infinite iterator for non-wildcard descriptors We would previously use `new_with_range`, which didn't check if the descriptor had a wildcard or not. This meant that for non-wildcard descriptors we created a spkiterator that would go on producing the same spk over and over again; this caused some scanning issues with electrum and esplora. To reproduce the bug, run in `example-crates/example_electrum`: ``` cargo run "sh(wsh(or_d(c:pk_k(cPGudvRLDSgeV4hH9NUofLvYxYBSRjju3cpiXmBg9K8G9k1ikCMp),c:pk_k(cSBSBHRrzqSXFmrBhLkZMzQB9q4P9MnAq92v8d9a5UveBc9sLX32))))#zp9pcfs9" scan ```
Co-authored-by: remix <[email protected]>
- Fix nomenclature after rebase - Flush stderr, not stdout - Always flush after printing in map/inspect - Fetch all the block anchors, not only the missing heights
LLFourn addressing his comments on bitcoindevkit#1040
4 tasks
LLFourn
force-pushed
the
esplora_example
branch
from
0dc88d5 to
45cbe6b
Compare
danielabrozzoni
force-pushed
the
esplora_example
branch
4 times, most recently
from
3c1e5d4 to
f41cc1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLFourn addressing his comments on bitcoindevkit#1040