Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Separate source files, build process, CommonJS & AMD support #3

Open
bgrohman opened this issue Aug 28, 2012 · 3 comments

Comments

@bgrohman
Copy link
Contributor

Evan,

As I'm looking at the code, I'm noticing that there isn't a lot of functionality right now being provided by jQuery. If you don't deliver this as a jQuery widget, it might make it easier to break up the code into separate files (to be combined and minified as part of a build using something like Anvil - https://github.com/arobson/anvil.js) and implement support for AMD and CommonJS (see https://github.com/rniemeyer/knockout-kendo/blob/master/src/knockout-kendo.js as an example that supports AMD and CommonJS and uses Anvil).

Thoughts?

@bgrohman
Copy link
Contributor Author

Here's how jQuery implements AMD: https://github.com/jquery/jquery/blob/master/src/exports.js. jQuery uses grunt for the build. Here's the config file - https://github.com/jquery/jquery/blob/master/grunt.js

@bgrohman
Copy link
Contributor Author

Here's an example gist for CommonJS/AMD support: https://gist.github.com/3498987

@evancarey
Copy link
Owner

Another great idea. Looks like I've got some reading to do.

On Tue, Aug 28, 2012 at 9:53 AM, Bryan Grohman [email protected]:

Evan,

As I'm looking at the code, I'm noticing that there isn't a lot of
functionality right now being provided by jQuery. If you don't deliver this
as a jQuery widget, it might make it easier to break up the code into
separate files (to be combined and minified as part of a build using
something like Anvil - https://github.com/arobson/anvil.js) and implement
support for AMD and CommonJS (see
https://github.com/rniemeyer/knockout-kendo/blob/master/src/knockout-kendo.jsas an example that supports AMD and CommonJS and uses Anvil).

Thoughts?


Reply to this email directly or view it on GitHubhttps://github.com//issues/3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants