Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added property to set transition name on the overlay #296

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Added property to set transition name on the overlay #296

merged 2 commits into from
Aug 23, 2018

Conversation

pietromanneschi
Copy link
Contributor

No description provided.

@euvl
Copy link
Owner

euvl commented Aug 23, 2018

Thanks, but in docs you called it differently to the code

@pietromanneschi
Copy link
Contributor Author

my bad.
Sorry i am not so used to github pull requests yet. I've fixed the readme, how can i commit the change to THIS pull request? Or do i have to make another one?

@euvl
Copy link
Owner

euvl commented Aug 23, 2018

You just have to commit in the same branch

@pietromanneschi
Copy link
Contributor Author

Thank you, committed

@euvl euvl merged commit fbbb081 into euvl:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euvl euvl euvl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pietromanneschi @euvl