Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add silver color #515

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add silver color #515

wants to merge 3 commits into from

Conversation

furushchev
Copy link
Member

  • Added silver color. This color is not defined in X11 but used many times in jskrbeusgl. I borrowed the value from http://prideout.net/archive/colors.php
  • Describe color query if it is not found like ;; Color name not found: :silver. Currently only Color name not found is displayed.
  • Cleaned up warning

k-okada
k-okada requested changes Jul 30, 2018
View reviewed changes
Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If you add new color. we'd better to have some background, such as X11 colors, for example html colors
    https://www.w3schools.com/colors/colors_names.asp, instead of add one color
  2. I'm afraid you have time to do this. need someone volunteer

@k-okada k-okada mentioned this pull request Nov 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-okada k-okada k-okada requested changes

Assignees
No one assigned
Labels
PR/WaitForMoreFeedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@furushchev @k-okada