Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epiforecasts-timeseries's automated submission #3358

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

epiforecasts-bot
Copy link
Collaborator

@epiforecasts-bot epiforecasts-bot requested a review from a team as a code owner January 8, 2024 13:26
@reneniehus
Copy link
Contributor

Many thanks for your submission, @sophiemeakin! We noticed that the filename of your submission reads "2024-01-07 ...", however, it should read "2024-01-08..." since it should indicate the Monday of the forecasting week. (See https://github.com/european-modelling-hubs/covid19-forecast-hub-europe/wiki/Submission-format).

1 similar comment
@reneniehus
Copy link
Contributor

Many thanks for your submission, @sophiemeakin! We noticed that the filename of your submission reads "2024-01-07 ...", however, it should read "2024-01-08..." since it should indicate the Monday of the forecasting week. (See https://github.com/european-modelling-hubs/covid19-forecast-hub-europe/wiki/Submission-format).

@reneniehus
Copy link
Contributor

The same applies to the forecast data column of the csv file. Please revise those dates accordingly. Many thanks

@sophiemeakin
Copy link
Contributor

Hi Rene, thanks for getting in touch. This submission is part of an automated submission from the Epiforecasts group - I'm tagged as I developed the original model, but I'm not currently actively working on this. @sbfnk should be able to help!
Thanks!

@reneniehus
Copy link
Contributor

@sbfnk , can you advise on this. I believe that merging this commit may cause issues due to the date. Is this something that can be fixed from your side

@sbfnk
Copy link
Contributor

sbfnk commented Jan 15, 2024

Yes, I should be able to fix this.

@sbfnk
Copy link
Contributor

sbfnk commented Jan 15, 2024

(the validations pass and in the past having this on the Sunday hasn't caused any issues but I can change it to be in line with the advice in the documentation)

@reneniehus reneniehus merged commit 0d0579a into main Jan 15, 2024
5 checks passed
@reneniehus reneniehus deleted the epiforecasts-timeseries branch January 15, 2024 19:37
@reneniehus
Copy link
Contributor

@sbfnk , many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants