-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metamenu] Metamenu plugin simply adds a menu to QMainWindow, which inte... #327
base: master
Are you sure you want to change the base?
Conversation
…ntegrates into unity-panel-service
|
||
bool MetamenuPlugin::load () | ||
{ | ||
QTimer::singleShot(2000, this, SLOT(shot())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need this timer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this timer i'll get null pointer of QMenuBar, because QMainWindow needs some time to be created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be it's better to make "chatWidgets" a Qt's property to be able to listen signals about it's changes? So you will be able to create a QMenuBar per each widget separatly with common MenuController
Conflicts: plugins/plugins.qbs
Conflicts: plugins/plugins.qbs
...grates into unity-panel-service